Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Roster): align with copy-html-entry constant #2215

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix(Roster): align with copy-html-entry constant #2215

merged 1 commit into from
Sep 19, 2024

Conversation

blaggacao
Copy link
Contributor

@blaggacao blaggacao commented Sep 18, 2024 •
edited
Loading

hrms/roster/package.json

Line 9 in ae828a8

"copy-html-entry": "cp ../hrms/public/roster/index.html ../hrms/www/roster.html"
is hard-coded to hrms while this was referencing the name of the folder.

They are not necessarily the same.

@blaggacao blaggacao mentioned this pull request Sep 18, 2024
Merged
@ruchamahabal ruchamahabal changed the title fix: align with copy-html-entry constant fix(Roster): align with copy-html-entry constant Sep 19, 2024
@ruchamahabal ruchamahabal merged commit 1807ca8 into frappe:develop Sep 19, 2024
7 checks passed
@blaggacao blaggacao deleted the fix/copy-html-entry branch September 19, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruchamahabal ruchamahabal ruchamahabal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blaggacao @ruchamahabal